[mythtv] Changeset 12793 breaks DTS passthru
Nigel Pearson
nigel at ind.tansu.com.au
Tue Apr 3 01:17:47 UTC 2007
> Changeset 12793 changes configure so it no longer sets CONFIG_DTS.
Indeed.
I am undecided if we should have separate symbols for the two things
(CONFIG_DTSLIB for the library that libavcodec uses to decode,
and CONFIG_DTS for the intention that our code should passthru DTS).
I suspect for maintenance reasons we should use one:
% svn diff libs/libmythtv/avformatdecoder.cpp programs/mythfrontend/
globalsettings.cpp
Index: libs/libmythtv/avformatdecoder.cpp
===================================================================
--- libs/libmythtv/avformatdecoder.cpp (revision 13169)
+++ libs/libmythtv/avformatdecoder.cpp (working copy)
@@ -8,7 +8,7 @@
using namespace std;
// MythTV headers
-#include "mythconfig.h" // for CONFIG_DTS
+#include "mythconfig.h" // for CONFIG_DTSLIB
#include "avformatdecoder.h"
#include "RingBuffer.h"
#include "NuppelVideoPlayer.h"
@@ -306,7 +306,7 @@
av_log_set_level((debug) ? AV_LOG_DEBUG : AV_LOG_ERROR);
allow_ac3_passthru = gContext->GetNumSetting("AC3PassThru",
false);
-#ifdef CONFIG_DTS
+#ifdef CONFIG_DTSLIB
allow_dts_passthru = gContext->GetNumSetting("DTSPassThru",
false);
#endif
Index: programs/mythfrontend/globalsettings.cpp
===================================================================
--- programs/mythfrontend/globalsettings.cpp (revision 13169)
+++ programs/mythfrontend/globalsettings.cpp (working copy)
@@ -151,7 +151,7 @@
return gc;
}
-#ifdef CONFIG_DTS
+#ifdef CONFIG_DTSLIB
static HostCheckBox *DTSPassThrough()
{
HostCheckBox *gc = new HostCheckBox("DTSPassThru");
@@ -2436,7 +2436,7 @@
VerticalConfigurationGroup *vgrp0 =
new VerticalConfigurationGroup(false, false, true, true);
vgrp0->addChild(AC3PassThrough());
-#ifdef CONFIG_DTS
+#ifdef CONFIG_DTSLIB
vgrp0->addChild(DTSPassThrough());
#endif
%
--
Nigel Pearson, nigel at ind.tansu.com.au|"Gentlemen,
Telstra Net. Eng., Sydney, Australia | you can't fight in here-
Office: 9202 3900 Fax: 9261 3912 | this is the war room!"
Mobile: 0408 664435 Home: 9792 6998 | Dr Strangelove
More information about the mythtv-dev
mailing list