[mythtv] [mythtv-commits] Ticket #3025: MythMusic configurable playback resume feature

Paul Harrison mythtv at dsl.pipex.com
Sun Apr 1 08:35:06 UTC 2007

Stuart Morgan wrote:
> On Saturday 31 March 2007 18:59:58 Paul Harrison wrote:
>> I didn't use the patch in the end it didn't work very well. My
>> implementation just bookmarks the route to the active node in the music
>> tree and restores that node when restarting. The big advantage is it
>> works fine if you have the 'Show entire music tree' setting turned on
>> and browse though your music that way.
> I might add an optional arg to play() for the start point, rather than calling 
> seek after play() - it's only slight and it might even be my imagination but 
> I can hear a fraction of a second of audio from the start of the track before 
> the seek.
Now you've pointed it out I can hear it too. Moving the seek into 
PlaybackboxMusic::play() just after the decoder->start() seems to fix it 
for me. Patch attached if you want to give it a try.
>>> One thing I did consider was the need for a 'Restart Playlist' option in
>>> the menu. Whilst many people would want it to resume where it was
>>> stopped, occasionally they'd want to reset playback to the start of the
>>> list without having to scroll back up to the top.
>> Sounds like a good idea. The pop menu is getting a little crowded but I
>> don't suppose one more item will make a big difference.
> It is getting crowded, that's something which may be addressed in a future 
> makeover, though I don't have any ideas yet.
>> I'm going to start expanding the metadata editor to show any found cover
>> art images next I think :-)
> I'll add those extra columns you wanted, unless you want to do that instead. 
> I'm re-writing eskils patch for reading Album Art from id3v2 tags to work 
> with the albumart table and the new tagging lib atm. There is some unfinished 
> work to be done on the album art visualiser too.

No problem I can add the required field.

Paul H.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: playbackbox.diff
Url: http://mythtv.org/pipermail/mythtv-dev/attachments/20070401/cac254dc/attachment.diff 

More information about the mythtv-dev mailing list