[mythtv] [11076] suspicious bitwise OR
Nigel Pearson
nigel at ind.tansu.com.au
Sat Sep 9 10:45:11 UTC 2006
> 719 if ((h_size % 16) | (v_size % 2))
> 720 return non_vec_yuv420_2vuy(image, py, pu, pv, h_size,
> v_size,
> 721 vuy_stride, y_stride,
> uv_stride);
>
> Logical or(||) instead?
The expressions are actually integers,
so I think it is equivalent, but in terms
of style, yes it should be changed.
I think I just cut & pasted one of the
existing ifs, so I will change the other
four too. Thanks for the change review!
--
Nigel Pearson, nigel at ind.tansu.com.au|"Things you own
Telstra Net. Eng., Sydney, Australia | end up owning you"
Office: 9202 3900 Fax: 9261 3912 | Tyler,
Mobile: 0408 664435 Home: 9792 6998 | Fight Club
More information about the mythtv-dev
mailing list