[mythtv] Ticket #2426: enhancement: embed playback box, move end of recording prompts to the OSD.

[Tom Lichti]

Justin Hornsby wrote:
> On 11/11/06, stanley kamithi <skamithi at gmail.com> wrote:
>   
>> Justin,
>>
>>  Yes it could be added to the OSD..or I could just leave it as an action
>> that you can bind to a remote button.
>>
>>  if folks don't want it, i won't do it.  i certainly don't want to waste my
>> time.
>>
>>
>> --
>>
>> Just a quick question...
>>
>> Is this going to add yet another item to the OSD menu?  It's starting
>> to look a bit busy in there IMHO.
>>
>> Justin
>>
>> ---
>>
>> On 11/10/06, Mark Buechler <mark.buechler at gmail.com> wrote:
>>     
>>> BTW, I'd like to thank you again for putting this together! In your
>>>       
>> original patch you had the ability in LiveTV to see the upcoming recordings
>> screen. Do you plan to add that as well?
>>     
>>> - Mark.
>>>
>>>
>>>
>>>       
>> _______________________________________________
>> mythtv-dev mailing list
>> mythtv-dev at mythtv.org
>> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
>>
>>
>>
>>     
>
> I'm certainly not against adding new features, lord no.  Bringing more
> options to the OSD menu & never being able to hide ones you don't use,
> that could become a bit of an eyesore.  That's all I'm saying.  Maybe
> as part of the UI rewrite there are already plans to make the OSD
> menus more themable.  If not, I think it'd be awesome to have.
>   
If you are ambitious you can use the attached patch as a guide to remove 
items you don't use. Mine is lean and mean now. It applies to current 
CVN, not sure about anything else.

Tom

osd_menu.diff:

Index: mythtv/libs/libmythtv/tv_play.cpp
===================================================================
--- mythtv/libs/libmythtv/tv_play.cpp   (revision 11450)
+++ mythtv/libs/libmythtv/tv_play.cpp   (working copy)
@@ -6276,7 +6276,7 @@
     }
     else if (StateIsPlaying(internalState))
     {
-        item = new OSDGenericTree(treeMenu, tr("Edit Recording"), 
"TOGGLEEDIT");
+/*        item = new OSDGenericTree(treeMenu, tr("Edit Recording"), 
"TOGGLEEDIT");

         item = new OSDGenericTree(treeMenu, tr("Jump to Program"));

@@ -6303,8 +6303,8 @@
             subitem = new OSDGenericTree(item, tr("Low Quality"),
                                          "QUEUETRANSCODE_LOW");
         }
+*/

-
         item = new OSDGenericTree(treeMenu, tr("Commercial Auto-Skip"));
         subitem = new OSDGenericTree(item, tr("Auto-Skip OFF"),
                                      "TOGGLECOMMSKIP0",
@@ -6318,7 +6318,7 @@
                                      "TOGGLECOMMSKIP1",
                                      (autoCommercialSkip == 1) ? 1 : 0, 
NULL,
                                      "COMMSKIPGROUP");
-
+/*
         if (playbackinfo->GetAutoExpireFromRecorded())
             item = new OSDGenericTree(treeMenu, tr("Turn Auto-Expire OFF"),
                                       "TOGGLEAUTOEXPIRE");
@@ -6327,7 +6327,7 @@
                                       "TOGGLEAUTOEXPIRE");

         pbinfoLock.unlock();
-
+*/
         item = new OSDGenericTree(treeMenu, tr("Schedule Recordings"));
         subitem = new OSDGenericTree(item, tr("Program Guide"), "GUIDE");
         subitem = new OSDGenericTree(item, tr("Program Finder"), "FINDER");
@@ -6338,7 +6338,7 @@
     FillMenuTracks(treeMenu, kTrackTypeAudio);
     FillMenuTracks(treeMenu, kTrackTypeSubtitle);
     FillMenuTracks(treeMenu, kTrackTypeCC708);
-
+/*
     if (VBIMode::NTSC_CC == vbimode)
         FillMenuTracks(treeMenu, kTrackTypeCC608);
     else if (VBIMode::PAL_TT == vbimode)
@@ -6372,7 +6372,7 @@
                                  
QString("%1").arg(kLetterbox_16_9_Stretch),
                                  (letterbox == kLetterbox_16_9_Stretch) 
? 1 : 0,
                                  NULL, "ASPECTGROUP");
-
+*/
     if (db_use_picture_attr)
     {
         item = new OSDGenericTree(treeMenu, tr("Adjust Picture"));
@@ -6393,10 +6393,10 @@
                                      QString("%1")
                                      .arg(kPictureAttribute_Hue));
     }
-
+/*
     item = new OSDGenericTree(treeMenu, tr("Manual Zoom Mode"),
                              "TOGGLEMANUALZOOM");
-
+*/
     item = new OSDGenericTree(treeMenu, tr("Adjust Audio Sync"), 
"TOGGLEAUDIOSYNC");

     int speedX100 = (int)(round(normal_speed * 100));
@@ -6404,12 +6404,13 @@
     item = new OSDGenericTree(treeMenu, tr("Adjust Time Stretch"), 
"ADJUSTSTRETCH");
     subitem = new OSDGenericTree(item, tr("Toggle"), "TOGGLESTRETCH");
     subitem = new OSDGenericTree(item, tr("Adjust"), "ADJUSTSTRETCH");
-    subitem = new OSDGenericTree(item, tr("0.5X"), "ADJUSTSTRETCH0.5",
+/*    subitem = new OSDGenericTree(item, tr("0.5X"), "ADJUSTSTRETCH0.5",
                                  (speedX100 == 50) ? 1 : 0, NULL,
                                  "STRETCHGROUP");
     subitem = new OSDGenericTree(item, tr("0.9X"), "ADJUSTSTRETCH0.9",
                                  (speedX100 == 90) ? 1 : 0, NULL,
                                  "STRETCHGROUP");
+*/
     subitem = new OSDGenericTree(item, tr("1.0X"), "ADJUSTSTRETCH1.0",
                                  (speedX100 == 100) ? 1 : 0, NULL,
                                  "STRETCHGROUP");
@@ -6422,13 +6423,14 @@
     subitem = new OSDGenericTree(item, tr("1.3X"), "ADJUSTSTRETCH1.3",
                                  (speedX100 == 130) ? 1 : 0, NULL,
                                  "STRETCHGROUP");
-    subitem = new OSDGenericTree(item, tr("1.4X"), "ADJUSTSTRETCH1.4",
+/*    subitem = new OSDGenericTree(item, tr("1.4X"), "ADJUSTSTRETCH1.4",
                                  (speedX100 == 140) ? 1 : 0, NULL,
                                  "STRETCHGROUP");
     subitem = new OSDGenericTree(item, tr("1.5X"), "ADJUSTSTRETCH1.5",
                                  (speedX100 == 150) ? 1 : 0, NULL,
                                  "STRETCHGROUP");
-
+*/
+/*
     // add scan mode override settings to menu
     FrameScanType scan_type = kScan_Ignore;
     bool scan_type_locked = false;
@@ -6474,6 +6476,7 @@
     subitem = new OSDGenericTree(item, "60 " + tr("minutes"), 
"TOGGLESLEEP60");
     subitem = new OSDGenericTree(item, "90 " + tr("minutes"), 
"TOGGLESLEEP90");
     subitem = new OSDGenericTree(item, "120 " + tr("minutes"), 
"TOGGLESLEEP120");
+*/
 }

 bool TV::FillMenuTracks(OSDGenericTree *treeMenu, uint type)