[mythtv] [mythtv-commits] Ticket #1864: Alternative xvattribute change

[Ivor Hewitt]

MythTV wrote:
>   * resolution:  => wontfix
>   * status:  new => closed
> 
> Comment:
> 
>  Nothing wrong this, but since we already have the current
>  implementation...
> 
Hi Daniel, sure, but I believe the current implemention isn't ideal 
though. Sure it works for having a default setting of 0 but the actual 
value change behaviour isn't ideal... let me explain.

The current change allows a default setting of zero and uses this to 
realign the hue attribute into the centre for a zero setting.

i.e. for setting values of 0-100 this gets the +50 adjustment added, 
hence: 50-150 and then mod(100) to give a range 50->100,0->50.
Therefore, when editing the hue value you if you want to reduce the hue 
slightly you need to increase the hue setting up to 50 at which point it 
will go back to the the lowest value when you hit 51 and you'll need to 
go all the way up to 99.

Since the default is the mid value and the usual behaviour will be to 
adjust up and down slightly from default, I think it's preferable to 
move the default into the centre instead.

I guess an alternative would be to allow the picture controls to wrap 
around.

Cheers,

-- 
Ivor
http://www.ivor.it