[mythtv] Refactored OSX backend firewire patch

[David Abrahams]

Nigel Pearson <nigel at ind.tansu.com.au> writes:

>> Here's a complete updated patch
>>
>> <darwin-backend.patch.bz2>
>
> 	I have started applying this. Sorry for the delay.
> Hope you are still around, and interested in this.

Somewhat.  Thinking of giving up on Myth and getting a TiVO (not
quite, but almost), but I'd like it if my work didn't go to waste.

>
> 1) Any chance of getting you to have another look at:
> libs/libmythtv/firewirechannel.cpp
> libs/libmythtv/firewirerecorder.cpp
> libs/libmythtv/firewirerecorder.h
>
> Those files have moved on far enough that I am not 100%
> sure about the patch rejects I am getting.

What kind of looking would you like me to do?

> 2) I am curious about this:
>
> Index: libs/libmythtv/tv_play.h
> ===================================================================
> --- libs/libmythtv/tv_play.h    (revision 9197)
> +++ libs/libmythtv/tv_play.h    (working copy)
> @@ -231,7 +231,7 @@
>       bool HasQueuedInput(void) const
>           { return !GetQueuedInput().isEmpty(); }
>       bool HasQueuedChannel(void) const
> -        { return queuedChanID || !GetQueuedChanNum().isEmpty(); }
> +        { return queuedChanID || !queuedChanNum.isEmpty(); }

I'm guessing this was done for efficiency reasons, after
profiling... but I can't say for 100% sure anymore.

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com