[mythtv] [mythtv-commits] mythtv commit: r9296 by danielk

[Stuart Auchterlonie]

On Wed, Mar 08, 2006 at 03:16:18PM +0000, mythtv at cvs.mythtv.org wrote:
>       Author: danielk
>         Date: 2006-03-08 15:16:12 +0000 (Wed, 08 Mar 2006)
> New Revision: 9296
>    Changeset: http://cvs.mythtv.org/trac/changeset/9296
> 
> Modified:
> 
>    trunk/mythtv/libs/libmythtv/mpeg/pespacket.cpp
>    trunk/mythtv/libs/libmythtv/mpeg/pespacket.h
> 
> Log:
> 
> Closes #1456, by adding a slightly modified version of Janne's patch for the CRC check on a packet with an invalid length.
> 
> When the CRC check is performed we do not know if the packet is valid, so it may contain an invalid length. This means we need to verify the length before performing the CRC check...
> 
> 

I've been poking around a bit looking at some of the backtraces relating
to other similar problems.

something I've noticed is that SIParser::ParseTable never checks the size
of the data it is passed, It's called from dvbsiparser after it has done
a read of a non zero number of bytes.

It is possible, though unlikely, that the read could return a number of
bytes that is less than the minimum required number of bytes to have a
valid packet. In this case we would be scribbling partial packets into
an buffer and then attempting to process them


Thoughts?


Stuart