[mythtv] [mythtv-commits] Ticket #1945: DVB-S/diseqc patch

Yeasah Pell yeasah at schwide.com
Wed Jun 28 13:37:09 UTC 2006


Daniel Kristjansson wrote:

><snip>
>Just make patches for each one. I'm strapped for time, but small patches
>I can often review while a compile is going or something like that.
>  
>
Sure, I'll do that as soon as I can, but between an impending product 
milestone, a 1-year old baby girl and home renovations I'm also a little 
strapped for time. :-)

>  
>
>> * The changes to libmyth/settings.cpp+h are needed for the device tree
>> editor to work properly. The change allows the myth listbox to have
>> multiple strings with the same displayed value, which is needed for the
>> GUI since the tree display is actually just an indented listbox -- and
>> tree nodes can easily have the same name.
>>    
>>
>I believe you duplicated a method that already exists under another name
>in a parent class. I forget the name at the moment but it shouldn't be
>hard to find, it is also a slot accepting an int...
>  
>
I think you're probably thinking about SelectSetting's public 
setValue(int) slot, which is similar but different -- it's meant to 
update the current selection (including the underlying widget's 
on-screen selection) programatically, hence it's a public slot. The 
method I changed is a protected slot, and it's meant to reflect changes 
to the widget's selection back to the ListBoxSetting object. The change 
doesn't add any functionality or anything, it just alters the specific 
mechanism for updating the current selection based on widget changes.

Previously it connected to the widget's highlighted(QString) signal that 
contained the string value of the selected item, and then somewhat 
perversely went through its own shadow array to figure out the index. 
Ignoring the inefficiency there, it doesn't work when you have multiple 
strings of the same value. So instead, the change causes it to use the 
widget's highlighted(int) signal that is emitted with the list index -- 
no need to look anything up, and it's immune to duplicated strings.

>  
>
>> On an unrelated note, if it's easy to take the new rotor position status
>> signal monitor value and stick it in the OSD, that would be a really nice
>> addition to this patch. I have a pretty rough understanding of the signal
>> monitor code, so I didn't want to do much more to that stuff than was
>> necessary in the patch.
>>    
>>
>This is easy, just look at UpdateOSDSignal(), the position should already
>be available there under the short name. (i.e. "snr", "seen_pat",
>"matching_pat", etc.). I believe you made the short name "pos".
>  
>
Excellent, I'll take a look when I can.

Many thanks,

Yeasah


More information about the mythtv-dev mailing list