[mythtv] Ticket #1049: DVBSignalMonitor needs to be able to monitor NIT/SDT

[Rudy Zijlstra]

Yeasah Pell wrote:

>Rudy Zijlstra wrote:
>
>  
>
>>Daniel Kristjansson wrote:
>>
>> 
>>
>>    
>>
>>>On Wed, 2006-06-07 at 08:50 -0400, Mark Buechler wrote:
>>>
>>>
>>>   
>>>
>>>      
>>>
>>>>It was actually the dst based Twinhan cards I had the most trouble
>>>>with. In correction, the Genpix 8psk module behaves like the Nexus in
>>>>that it works well with rotors and tuning.
>>>>Once the new DiSEqC stuff goes in, within the new tuning process after
>>>>the rotor is estimated to be at its desired location, and the tuing
>>>>code retunes, I think we should retune every few seconds until a lock
>>>>is gotten. Given how the dst based cards behave, if we don't retune
>>>>several times then we're very highly dependant on rotor movement speed
>>>>estimates. 
>>>>  
>>>>
>>>>     
>>>>
>>>>        
>>>>
>>>I can move the retune stuff to the signal monitor. This is much cleaner
>>>than keeping the code in TVRec, and should allow us to only do the
>>>retune when we don't have a lock on the proper multiplex.
>>>
>>>
>>>
>>>
>>>   
>>>
>>>      
>>>
>>Please do. last night i upgraded to current SVN (10180). I could no 
>>longer tune my budget DVB-S card. Reverted this morning to 10131 and 
>>tuning was OK. When going to 10132 i loose tuning on the card and can 
>>only watch services on the already tuned TS.
>>
>>Cheers,
>>
>>Rudy
>>
>> 
>>
>>    
>>
>Actually this is probably due to a bug in libs/libmythtv/dvbchannel.cpp 
>that I fixed last night, which was unmasked recently by the 
>intramultiplex changing support (which is great, thanks!)
>
>The problem is that dvbchannel.cpp gives a band of +/-500000 when 
>considering if the two frequencies are equal, but DVB-S frequencies are 
>in kHz, so it should be 500 for DVB-S or DVB-S2 -- otherwise it has a 
>band of 500MHz when comparing frequencies, so it doesn't do a lot of 
>tuning requests. :-) I have a proper fix in my diseqc/dvb-s patch, but 
>if you want to workaround quickly, just change that one line's value 
>from 500000 to 500 for now.
>
>I think there may be other areas where the kHz/Hz confusion comes in, 
>I've definitely spotted places in the GUI anyway (when you're putting in 
>the tuned scan parameters for example, as I recall the help text says 
>Hz, but that's wrong for DVB-S)
>
>/y
>  
>
I am not a very good code reader.... Which line should i change?

I'll test and come back.

Rudy