[mythtv] [mythtv-commits] mythtv commit: r10633 by danielk
Daniel Kristjansson
danielk at cuymedia.net
Mon Jul 24 22:21:04 UTC 2006
On Mon, 2006-07-24 at 18:13 -0400, Chris Pinkham wrote:
> * On Mon Jul 24, 2006 at 10:05:12PM +0000, mythtv at cvs.mythtv.org wrote:
> > Author: danielk
> > Date: 2006-07-24 22:05:11 +0000 (Mon, 24 Jul 2006)
> > New Revision: 10633
> > Changeset: http://cvs.mythtv.org/trac/changeset/10633
>
> Is gcc going to handle not creating (or initting) this QString each time
> through the loop inside ThreadedFileWriter::DiskLoop()?
>
> 385 QString msg =
> 386 "Maximum file size exceeded by '%1'\n\t\t\t"
> 387 "You must either change the process ulimits, configure\n\t\t\t"
> 388 "your operating system with \"Large File\" support, or use\n\t\t\t"
> 389 "a filesystem which supports 64-bit or 128-bit files.\n\t\t\t"
> 390 "HINT: FAT32 is a 32-bit filesystem.";
> 391
> 392 if (!ignore_writes && !write_ok && (EFBIG == errno))
> 393 {
> 394 VERBOSE(VB_IMPORTANT, msg.arg(filename));
> 395 ignore_writes = true;
> 396 }
>
> Any reason not to put the declaration inside the if statement?
Just formatting. I'll move it inside the if statement, just in case gcc
does create the string everytime through the loop.
-- Daniel
More information about the mythtv-dev
mailing list