[mythtv] Internal dvd player: patch from ffmpeg alias to address mpeg sequence end codes.

stanley kamithi skamithi at gmail.com
Fri Feb 24 21:09:50 UTC 2006


For folks who are testing the internal dvd player, and using DVB, please
apply the attached patch I got from the ffmpeg alias.
Let me know if it breaks DVB playback.


---------- Forwarded message ----------
From: elupus <elupus at ecce.se>
Date: Feb 24, 2006 8:33 AM
Subject: RE: [Ffmpeg-devel] Demuxing still pictures in dvd's II
To: FFMpeg development discussions and patches <ffmpeg-devel at mplayerhq.hu>

Had a look at this again, think I found a solution similar to stanley
kamithi. Had some problems understanding ff_find_start_code, maybe some
documentation on that function is in order, pain to understand what happens
in different cases :).

Anyway attatched is a patch that hopefully should fix this. I've not
verified it in our own dvd player yet, however maybe stanley could in his.
The difference between this one and stanley's is just that it only check the

last state found. I don't think this should cause any problems. So the only
change will be if no startframe is found in the buffer.

Found some other odity too.. If buffer is empty (eof) no startcode will be
found in the first loop, so frame_start_found will never be set to true.
Means no end will be found either. Is the idea behind the function to first
make sure there is a frame contained in the buffer and then find the end
code? Wouldn't it be better to make sure the caller knows there is a frame
in the buffer and only look for the end (ie start of next frame or
SEQ_END_CODE whatever comes first).


ffmpeg-devel mailing list
ffmpeg-devel at mplayerhq.hu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mythtv.org/pipermail/mythtv-dev/attachments/20060224/16e62d2e/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpeg12.c.patch
Type: application/octet-stream
Size: 847 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20060224/16e62d2e/attachment.obj 

More information about the mythtv-dev mailing list