[mythtv] [mythtv-commits] Ticket #1043: Internal DVD Menu Support and Position Bar Support.

[Anthony J. Mirabella]

Isaac Richards wrote:
> On Wednesday 15 February 2006 15:58, Anthony J. Mirabella wrote:
>> This is actually working for me, which is an improvement over the last
>> time I tried it, but it's not quite working right.  The problem seems to
>> be with the display of still frames in menus.  I thought something was
>> wrong when I put in a dvd and saw the buttons for the menu but no
>> background image.  I then changed to the chapter select menu and the
>> background for the main menu showed.  Changing to a new chapter select
>> menu or the main menu made the background for the first chapter select
>> menu show.  I think you get the idea.  It seems to not be actually
>> displaying the still frame when it gets a DVDNAV_STILL_FRAME event.
>> Menus with video seem to work fine though switching from a menu with
>> video to a still menu leaves the last frame of the video menu displayed.
> 
> That's the change I left out, I believe.
> 
> Isaac
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
> 

Ok, putting in that change does affect still menus, but doesn't quite
fix them.  The DVD I'm testing with plays a short logo video then has a
still main menu.  With the change reinserted the behavior is now that
the main menu doesn't show, nor does the chapter menu, but after
selecting the chapter menu going back to the main menu results in the
menu showing fine, and the chapter menu works after that.  Going to the
second level of the chapter menu, where thumbnail videos are shown, and
backing out leaves the last frame of the video playing but going back
and forth between main and chapter menus once will get it displaying the
still menus again.

Also, looking at my logs with -v playback I noticed what's probably a
cut and paste error in DVDRingBuffer.cpp that this patch should fix:

Index: DVDRingBuffer.cpp
===================================================================
--- DVDRingBuffer.cpp   (revision 8966)
+++ DVDRingBuffer.cpp   (working copy)
@@ -115,7 +115,7 @@
             {
                 dvdnav_get_number_of_parts(dvdnav, curTitle, &titleParts);
                 VERBOSE(VB_IMPORTANT,
-                        QString("There are title %1 has %2 parts.")
+                        QString("Title %1 has %2 parts.")
                         .arg(curTitle).arg(titleParts));
             }
         }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20060215/25fae057/signature.pgp