[mythtv] mytharchive passes bad mediatype values in config.xml?

Aran Cox spin667 at mchsi.com
Tue Aug 8 03:18:04 UTC 2006


On Mon, Aug 07, 2006 at 04:55:22PM -0500, Aran Cox wrote:
> When I specify a DVD DL disk, the mediatype is often some seemingly
> random number in the config.xml file.  This is with todays
> mythplugins/mytharchive.  I saw this in earlier versions as well.
> 
> This causes mythburn to run tcrequant on my recordings to squeeze them
> down to fit on a single layer disk.  The dvdrsize value is set
> correctly, but I think mythburn must be expecting a mediatype of 1.
> Also, it seems that I saw mytharchive put a 0 in for mediatype when I
> specified DVD+RW as well.
> 
> Line 1242 of mythburnwizard.cpp does this:
> 
>     options.setAttribute("mediatype", archiveDestination.type);
> 
> But I don't see where archiveDestination is populated, or where it
> should be populated.  I'll have another look if no one else can fix
> it... I'll also file a bug if someone thinks I should.

This little patch just sets archiveDestination in
MythburnWizard::setDestination. 

I guess I'll create a trac ticket so it doesn't get lost in the
shuffle.  The patch seems to fix all the issues I had with getting the
wrong values in mediatype in the config.xml file.

-------------- next part --------------
Index: mytharchive/mytharchive/mythburnwizard.cpp
=================================--- mytharchive/mytharchive/mythburnwizard.cpp	(revision 10698)
+++ mytharchive/mytharchive/mythburnwizard.cpp	(working copy)
@@ -1399,6 +1399,8 @@
         destination_text->SetText(ArchiveDestinations[item].description);
     }
 
+    archiveDestination=ArchiveDestinations[item];
+
     switch(item)
     {
         case AD_DVD_SL:


More information about the mythtv-dev mailing list