[mythtv] Ticket #1678: mythvideo sorting is case-sensitive

George Nassas gnassas at mac.com
Sat Apr 22 01:28:02 UTC 2006


On 21-Apr-06, at 5:35 PM, Anduin Withers wrote:

> Your static indicator may require some adjustments.

There was also an earlier, pointless, exchange. I'd prefer to focus on 
code issues but the basic story is I considered my and the reviewer's 
time, weighed it against the nature of the changes and decided to 
submit as is. Someone else might do it differently. Fair enough. On a 
different day I might also. I'm not interested in repeated grief on the 
topic.

> 3) Those allocations and comparisons are meaningless in the face of 
> other
> inefficiencies in there. That isn't to say efficiency doesn't mater, 
> but

Agreed. However, I'm thinking of my swap-happy xbox with a mere 64MB 
and some of that is shared with video. It's always on the edge of 
thrashing so I'm wary of pushing it over. Yes, it's probably not such a 
big deal but that's where I'm coming from. That and a general distaste 
for inefficiency.

In any case the two patches change the same method in an incompatible 
way so something has to be done. I can pull the sorting class into my 
cleanup patch and resubmit if you wish. It wouldn't be that much more 
to review plus mythvideo is pretty simple and I'm not doing anything 
scary anyway. I'm not set up for patch management so I'd prefer not to 
do a hand edit to break up my #1569 patch.

Oh, if by patch management you mean something like weave then I have 
that although I haven't found time to get up to speed with it. Normally 
I don't have more than one or two patches on the go.

- George



More information about the mythtv-dev mailing list