[mythtv] Patch proposal for better logging of ivtv select timeouts

[Daniel Kristjansson]

On Sat, 2006-04-15 at 02:53 -0400, f-myth-users at media.mit.edu wrote:
>     > Date: Thu, 13 Apr 2006 10:52:33 -0400
>     > From: Daniel Kristjansson <danielk at cuymedia.net>
>     > Nope, but if you change the cerr redirects and printfs to the proper
>     > verbose macros that would be appreciated and accepted. Assign the ticket
>     > to 'danielk' for the quickest response.
> 
> Some questions:
> 
>     >     cerr << "Audiorate(L1): " << value << " is invalid\n";
>     > becomes
>     >     VERBOSE(VB_IMPORTANT, LOC_ERR +
>     >             QString("Audiorate(L1 %1) is invalid").arg(value);
> 
> Did you mean LOC here and not LOC_ERR?  Or perhaps both your examples
> are true errors but elsewhere in that file are some non-errors that
> will want to use LOC?  (This may become obvious when I look through
> the rest of the logging there.)
Use your judgement, I don't know how serious this problem is. Basically,
VB_IMPORTANT messages should use LOC_ERR, VB_GENERAL messages should use
LOC_WARN, and VB_RECORD messages should use LOC. But sometimes and
informative, non-error, message is very important so then you might
use VB_IMPORTANT with LOC.

>     > #define LOC QString("IVTVRec(%1) Error: ").arg(videodevice)
> I presume you meant the latter macro to be
> #define LOC_ERR QString("IVTVRec(%1) Error: ").arg(videodevice)
Yes, copy-n-paste strikes again :)

Also, normally less invasive patches are preferred, but in this case the
problem is something we've solved in other classes in a standardized way
and I would like to solve it the same way here.

-- Daniel