[mythtv] If making an unrecognised gesture with the mouse, it defaults as "Up" instead of MaxGesture
Paul Andreassen
paulx at andreassen.com.au
Thu Apr 6 11:23:29 UTC 2006
On Thu, 6 Apr 2006 05:55 pm, florin baiduc wrote:
> Anyone has a solution or explanation for this? I made a patch here,
> but somehow it gets rejected. Why?
> here's the link:
> http://svn.mythtv.org/trac/ticket/1634
> Thanks for the constructive criticism while closing my ticket.
Thanks for the patch but please read the closing comment.
"Patch is broken. Different indentation style than existing code, has
unnecessary code (both changes + new), etc."
The Patch is broken because it uses a different indentation style. For
example using tabs instead of four spaces.
The Patch is broken because it has unnecessary code. Changing MaxGesture to
WrongGesture is not acceptable. Changing adjustExtremes is not necessary and
make it more complex.
Paul
--
More information about the mythtv-dev
mailing list