[mythtv] Ticket #1272: preview or lcd qsocket related segfault

[Jim Westfall]

Steven Adeff <adeffs.mythtv at gmail.com> wrote [03.31.06]:
> On 3/31/06, Paul Wheeler <paulrwheeler at gmail.com> wrote:
> > Daniel
> >
> > This occurs on my single frontend/backend box (which also has an lcd
> > screen) by disabling the lcd and recordings preview i havent seen it
> > crash again, renabling lcd will cause it to crash, havent tried just
> > the recording preview (it may be a red herring). When streaming to a
> > remote frontend i do not experience crashes (with or without the lcd
> > enabled). I just use the inbuilt myth protocols over g wireless with
> > standard uk dvb streams.
> >
> > Paul
> >
> > On 3/31/06, MythTV <mythtv at cvs.mythtv.org> wrote:
> > > #1272: preview or lcd qsocket related segfault
> > > ------------------------------------+---------------------------------------
> > >  Reporter:  paulrwheeler at gmail.com  |        Owner:  danielk
> > >      Type:  defect                  |       Status:  new
> > >  Priority:  minor                   |    Milestone:  0.20
> > > Component:  mythtv                  |      Version:  head
> > >  Severity:  medium                  |   Resolution:
> > > ------------------------------------+---------------------------------------
> > > Comment (by danielk):
> > >
> > >  Are you by any chance using streaming between the backend and frontend,
> > >  rather than an NFS/Samba share?
> > >
> > >  Jim Westfall recently reported a race condition in streaming, which might
> > >  explain this segfault...
> > >
> 
> I've had this same issue, with the same fix, I opened a ticket
> http://svn.mythtv.org/trac/ticket/1245 a while back with a few
> backtraces and a comment from Isaac.
> 
> Which sucks, cause I haven't had use of my LCD for a few weeks, it
> just sits there with the LCDProc default message...
> 

can you give the attached patch a try.

jim
-------------- next part --------------
Index: libs/libmyth/lcddevice.cpp
===================================================================
--- libs/libmyth/lcddevice.cpp	(revision 9585)
+++ libs/libmyth/lcddevice.cpp	(working copy)
@@ -153,7 +153,7 @@
 
     if (!connected)
     {
-        QTextStream os(socket);
+        QTextStream os(socket->socketDevice());
 
         int count = 0;
         do
@@ -216,7 +216,7 @@
         return;
     }
 
-    QTextStream os(socket);
+    QTextStream os(socket->socketDevice());
    
     last_command = someText;
  
@@ -227,7 +227,7 @@
 #endif
         // Just stream the text out the socket
 
-        os << someText << "\n" << flush;
+        os << someText << "\n";
     }
     else
     {