[mythtv] Re: [mythtv-commits] mythtv commit: r7363 - in trunk/mythtv/libs bydanielk

Mark Spieth mark at dclabs.com.au
Fri Sep 30 14:24:31 UTC 2005


daniel,
your fix to utils.c wont work.
probably should be
if (!*ppktl)
as the address will always be ok.
the main problem is probably that av_read_frame doesnt get any frames and
thus there is no av stream info.
the test could easily be put  into avformatdecoder thus avoiding changes to
libav/ffmpeg stuff which will make isaacs merging easier.
if you like Ill generate a patch tomorrow but first I have to sync with HEAD
and test.
cheers
mark

----- Original Message ----- 
From: <mythtv at cvs.mythtv.org>
To: <mythtv-commits at mythtv.org>
Sent: Friday, September 30, 2005 11:57 PM
Subject: [mythtv-commits] mythtv commit: r7363 - in trunk/mythtv/libs
bydanielk


>       Author: danielk
>         Date: 2005-09-30 13:57:23 +0000 (Fri, 30 Sep 2005)
> New Revision: 7363
>    Changeset: http://cvs.mythtv.org/trac/changeset/7363
>
> Modified:
>
>    trunk/mythtv/libs/libavformat/utils.c
>    trunk/mythtv/libs/libmythtv/NuppelVideoPlayer.cpp
>    trunk/mythtv/libs/libmythtv/videoout_null.cpp
>
> Log:
>
> Few fixes that should address SEGFAULT problems with NVP::GetScreenGrab().
>
> * The change in utils.c fixes the immediate cause of
>   Jack Hide's SEGFAULT.
> * The changes in NVP adds data verification & error messages,
>   and initializes variables earlier for easier debugging.
> * The change in videoout_null.cpp adds a check for valid dimensions.
>
>
>
>
>


----------------------------------------------------------------------------
----


_______________________________________________
mythtv-commits mailing list
mythtv-commits at mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits



More information about the mythtv-dev mailing list