[mythtv] Re: [mythtv-commits] Re: Ticket #255: Improved scheduling of consecutive programs with pre-roll/overrecord

David Engel gigem at comcast.net
Wed Sep 28 22:47:35 UTC 2005

On Wed, Sep 28, 2005 at 04:16:43PM +1000, Max Barry wrote:
> gigem at comcast wrote:
> >First, you are querying a number of settings from within loops. This
> >causes Myth to needlessly fetch things over and over again from the
> >database. The relevant settings should be queried once per scheduler
> >pass.
> Ah, of course, sorry. I'm happy to fix this. Am I right in thinking that 
> you're referring to lines 905, 926, and 930 of my patch to scheduler.cpp?

Our line numbers probably don't agree anymore.  I'm talking about any
calls to GetNumSetting you added in scheduler.cpp that aren't done in

> >Second, I agree with Bruce that this option isn't needed.
> I must have misunderstood an earlier e-mail of yours, David, because I 
> thought you requested this. It's not something I need. (Although does it 
> really hurt to have the option?) You mentioned that people seemed to be 
> asking for a global hard setting, so while I was here, I thought I'd 
> give it to them.

I changed my mind and think it's better to use the existing hard
settings for this instead of muddying the waters.

> Otherwise you end up with multiple settings for what is, at least at 
> first glance, the same thing. If a new pair of global setting was added, 
> MythTV would have 3 different ways to set pre- and post- buffers (two 
> global, one rule-specific), which seems a little excessive.

No, they really are different, and if taken beyond your current patch,
they could be even more different.  Also, Bruce's suggestion that
viewscheduled should leave the guess work out and show exactly what
will happen carries a lot of weight with me.  That would already would
require going beyond your patch.

David Engel
gigem at comcast.net

More information about the mythtv-dev mailing list