[mythtv] Re: [mythtv-commits] Re: Ticket #385: DVBChannel cleanup

Kevin Kuphal kuphal at dls.net
Wed Sep 28 13:27:39 UTC 2005


Colin McCormack wrote:

>>#385: DVBChannel cleanup 
>>Changes (by ijr):
>>
>>  * resolution:  => invalid
>>  * status:  reopened => closed
>>
>>Comment:
>>
>> Then stop wasting my time and submit a patch without unnecessary
>>    
>>
>changes
>  
>
>> in it.
>>    
>>
>
>Wow.  I have seldom seen such incivility for such a clueless reason,
>unless an underdosage of major tranquilizers was involved.
>
>Someone cleans up some code for you, removing redundant includes, and
>they are accused of wasting your time.  They make the point that every
>compilation by every user is going to be slightly longer because of the
>boneheaded inclusion of unnecessary include files, and you accuse *them*
>of wasting *your* time?
>
>  
>
You seem to be missing the point.  First, your patch changes more than 
just some include statements which qualifies as "unnecessary changes".   
It is entirely possible that Isaac is commenting solely on that.  
Secondly, the includes, while perhaps not necessary for you to compile, 
may not be the case for others.  Not only does MythTV work on both Linux 
and MacOS X, but even I have seen issues on my Redhat 9 system where I 
needed extra includes that others did not.

Kevin


More information about the mythtv-dev mailing list