[mythtv] Re: [mythtv-commits] mythtv commit: r7481 by danielk
Isaac Richards
ijr at case.edu
Sat Oct 15 01:00:35 UTC 2005
On Friday 14 October 2005 08:31 pm, mythtv at cvs.mythtv.org wrote:
> Author: danielk
> Date: 2005-10-15 00:31:07 +0000 (Sat, 15 Oct 2005)
> New Revision: 7481
> Changeset: http://cvs.mythtv.org/trac/changeset/7481
>
> Modified:
>
> trunk/mythtv/programs/mythfrontend/playbackbox.cpp
> trunk/mythtv/programs/mythfrontend/playbackbox.h
>
> Log:
>
> Stops playbackbox from blocking on preview generation.
>
> If the preview doesn't exist we create a thread to create
> one and use a blank preview until the non-blank one has
> been generated. Once the preview is generated a redraw
> event is scheduled and we get to see the preview.
This'll leak threads & also crash if you exit the playback window while it's
creating a preview. Old way was fine, since creating previews is only a one
time cost per recording. A better way to accomplish this would be to make
the backend generate the preview after it's done with the recording.
Isaac
More information about the mythtv-dev
mailing list