[mythtv] Re: [mythtv-commits] mythtv commit: r7448 by bjm

Bruce Markey bjm at lvcm.com
Tue Oct 11 17:25:54 UTC 2005


Neale Swinnerton wrote:
>>      Author: bjm
>>        Date: 2005-10-11 07:16:08 +0000 (Tue, 11 Oct 2005)
>>New Revision: 7448
>>   Changeset: http://cvs.mythtv.org/trac/changeset/7448
>>
>>Modified:
>>
>>   trunk/mythtv/programs/mythfrontend/customrecord.cpp
>>
> 
> 
> Isn't bindValue() prefered to creating a QString so that you handle quotes
> etc better?

Heh, that's what I was thinking when I created the bug the day
before.  bindValue() makes the arg into a single quoted field. So,
instead of testing the WHERE clauses, it was testing "WHERE 'quoted
sting'" which is always true and tells us nothing about how the
clauses would be interpreted.

Here, the search criteria is added to the rest of the query string
with QString just as it is in proglist and the scheduler and finds
the same typos as it would if the search got passed down the line.

--  bjm


More information about the mythtv-dev mailing list