[mythtv] New MPEG2 commercial-cut code ready for testing

Bryan Mayland bmayland at leoninedev.com
Mon Nov 21 15:28:08 EST 2005


Geoffrey Hausheer wrote:
> All versions since I added the PTS wrap code have had assorted issues.
>   
    I was just coming here to let you know this....
> I checked in some more fixes into svn which should help, though I'm
> still not convinced it is right.
>   
    ...until I saw this.  [7964] fixed the "Deadlock detected!" I was 
getting.
   
One thing I find unusual about the mythtranscode version is that when 
you specify to "--honorcutlist" or -l, it expects you to pass the 
cutlist on the command line if you specify an input file instead of a 
chanid and starttime.  This behavior seems unintuitive (although I can 
see why someone would want to pass a cutlist on the command line). 

I would think that passing a cutlist on the command line should override 
the use of the one in the database, but the cutlist should be loaded 
from the DB is --honorcutlist is used and no cutlist is passed on the 
command line.  Maybe I'm thinking about it the wrong way, but that would be:
Index: main.cpp
===================================================================
--- main.cpp    (revision 7965)
+++ main.cpp    (working copy)
@@ -395,7 +395,7 @@
     int exitcode = TRANSCODE_EXIT_OK;
     if ((result == REENCODE_MPEG2TRANS) || mpeg2)
     {
-        if (useCutlist && !found_infile)
+        if (useCutlist && deleteMap.isEmpty())
             pginfo->GetCutList(deleteMap);

         MPEG2fixup *m2f = new MPEG2fixup(infile.ascii(), outfile.ascii(),



More information about the mythtv-dev mailing list