[mythtv] [PATCH] mythgallery: move .thumbcache out of image directory

Eggert Thorlacius eggi-spam at menandmice.com
Thu May 26 22:56:55 UTC 2005


On 23.5.2005, at 14:14, Ed W wrote:

>
>
>> On 15.4.2005, at 22:20, Eggert Thorlacius wrote:
>>
>>
>>> This small patch adds a checkbox to the MythGallery Settings page  
>>> where the user can choose between the current functionality of  
>>> storing .thumbcache directories inside the image directory or  
>>> storing them in ~/.mythtv/mythgallery/
>>>
>>> This makes it possible to use MythGallery to browse a read-only  
>>> directory
>>>
>>
>>
>
> I'm not sure if there was a reason why this patch never made it to  
> CVS, but it works really nicely for me (I mount my photos share  
> read-only for safety...).
>
> I have modified it so that actually the settings flag acts as an  
> over-ride, but actually it also uses the local home dir if it finds  
> that the gallery dir is read-only for any reason.  This means that  
> you can eithe force it locally or let it auto-detect.  Perhaps this  
> removes one of the main objections from before?


The way I understoood Isaacs comment, that was indeed the reason why  
it was not applied.  I was going to change it but never had the time  
and now you seem to have beat me to it.
One thing I was wondering about, though: If the code falls back to  
~/.mythtv when the gallery dir is read-only, do we still need the  
checkbox?  Wouldn't it be enough to mention it in the docs that if  
you don't like .thumbcache dirs, you should not give the mythtv user  
write access to the image dir?

Eggert


More information about the mythtv-dev mailing list