[mythtv] Re: [PATCH] EPG Improvements

[Harvard Pan]

Please find the latest patch at:

http://home.comcast.net/~harvardpan/EPGUpdated5142005.diff.bz2

Changes:
1. I wasn't passing anything into SendResponse which was causing the
backend to not respond correctly. I now pass "0" in the server
response if no free recorders are found.
2. I changed the dialog for the error message to be a popup box
instead. A full dialog is not really that necessary.

--Harvard

On 5/14/05, Harvard Pan <harvardpan at gmail.com> wrote:
> Isaac,
> 
> I changed the GetCurrentChannel because it was getting the wrong
> value. I didn't track down the problem, but what I found was that it
> was returning "0.625" for me. Not quite sure where that value could
> have come from. I was originally calling GetCurrentChannel, but now
> I've changed my code to not call that anymore, so if you want to
> revert the code, that's ok with me. Someone should eventually track
> down why it's saving the wrong value though (I'll probably try to do
> that this weekend)
> 
> Brian also found one more issue with my patch that I'm currently
> looking into right now. If you haven't already applied the patch,
> please wait until I post the next version on my web site.
> 
> thanks!
> Harvard
> 
> On 5/13/05, Isaac Richards <ijr at case.edu> wrote:
> > On Thursday 12 May 2005 03:09 am, Harvard Pan wrote:
> > > Many thanks to Brian Huffman for testing my patch and finding serious
> > > issues after I introduced the dialog. Hopefully, I've worked out the
> > > kinks. I have put a new version of the diff on my web site.
> > >
> > > The new file location is:
> > >
> > > http://home.comcast.net/~harvardpan/EPGUpdated5112005.diff.bz2
> > >
> > > If anyone finds anything wrong with the patch, I'd appreciate feedback
> > > so that I can resolve it as soon as possible.
> >
> > What's the reasoning behind the GetCurrentChannel change?  That's quite
> > helpful to save a backend query..
> >
> > I'm applying most of this patch at the moment, btw..
> >
> > Isaac
> > _______________________________________________
> > mythtv-dev mailing list
> > mythtv-dev at mythtv.org
> > http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
> >
>