[mythtv] [PATCH] DBOX2 Feed Implementation 2005-05-10

[Levent Guendogdu]

Taylor Jacob wrote:

>>attached you will find the implementation for using the DBOX2 as a
>>MythTV DVB source.
>>
>>Features:
>>   - using the Nokia/Sagem/Philips DBOX2 as a video source for MythTV
>>   - multiple DBOX2s can be used
>>   - grabs a complete TS stream from the DBOX2 using SPTS mode (all
>>audio streams available in myth)
>>   - automatic EPG scan of all DBOX2 channels when recorder/livetv is
>>inactive
>>    
>>
>
>Why are you not using the dtvrecorder base class, and siparser classes?  I see
>no point in duplicating code in numerous places through myth.
>  
>
take a look in dbox2recorder.h:

    class DBox2Recorder : public QObject, public DTVRecorder

I clearly use the recorder ;)

I cannot use the SI-Parser though, since I use things differently. I 
also need to override special fields in the PMT and PAT, which are not 
the same as the DVB stuff does it (this is due to DBOX2 
hardwarefiltering of the tables). I use the original PMT which has a 
different SID. I rewrite the PMT each time it comes in and create a PAT 
accordingly.
That's why it might look like code duplication at first glance.

I admit some #defines are duplicated. I might clean those up in future 
versions as well.

Bye,
 Levon