[mythtv] [PATCH] Fix (now broken) screen settings

[Daniel Kristjansson]

On Wed, 2005-03-23 at 12:34 +1100, Nigel Pearson wrote:
> > implementation by implementing GetDisplaySize(). But I don't have
> > a MacOSX system to compile on so this may not even compile.
> 
>       Indeed it didn't :-)
(-: Thanks for getting that working

>       Just the CFReleases, right? I thought they would be needed,
> but adding them caused the app to crash somewhere in CoreGraphics
> when opening the screen, so it looks like they shouldn't be there.
Yep, I guess those arrays are owned by the framework.

> 2a) GetNumberOfXineramaScreens() could easily be replaced
> with Qt's QApplication::desktop()->numScreens(),
> which also works on OS X, Windows, et c.
I kept this, my reasoning was in the last reply, basically I don't
think Qt distinguishes between Xinerama screens, virtual screens,
and virtual desktops properly.

> 2b) I was trying to keep util.cpp as a set of "utility"
> sort of code (i.e. OS and file sort of stuff), hence the
> removal of the X11 specific stuff in my multiscreen patch.
> GetDisplayModes() maybe belongs elsewhere?
> (But mythcontext is getting crowded,
>   so I don't know where else to put it)
I removed everything but the GetNumberOfXineramaScreens(), I just don't
know where it would go. Maybe we need a x11-utils.h? or a
xinerama-utils.h?

I've attached a patch that should also fix some of John Poet's problems.
That is, we now try to get the old style GUI video mode, and if this
doesn't work, we default to 640x480. This means you shouldn't end up in
some video mode that is just barely supported by your monitor.

-- Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: display-res-v2.tbz
Type: application/x-bzip
Size: 16414 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20050324/8bdcb5cb/display-res-v2.bin