[mythtv] Re: [PATCH] Save program guide data with recordings

David Engel gigem at comcast.net
Wed Mar 23 16:15:07 UTC 2005


Boy, you weren't kidding about getting patch happy!

On Wed, Mar 23, 2005 at 01:39:13AM -0500, Isaac Richards wrote:
> On Sunday 20 February 2005 09:44 pm, Colin Cross wrote:
> > This patch adds support for saving the guide data for recordings,
> > including the credits.  It modifies the following files
> 
> I've applied this, thanks..

Colin, I have a few questions/issues regarding this change.

1. How hard would it have been to not delete the relevant info from
   the original tables if a recording was still present?

2. The starttime in the recorded table is the time the recording was
   started, not the starttime from the program table.  So, if a
   program starts recording early or late, I don't think the info in
   the new tables will be available.

3. Because of #2, the info in the new tables won't be deleted when the
   recording is deleted.

4. It's minor and maybe not worth fixing, but I don't think you should
   save (and delete) new info for manual recordings.

If you stick with the current approach for #1, I see two possible
fixes for #2 and #3.  First, you could save both program and recording
times in the recorded table.  Second, you could munge the starttimes
in the new tables to match the recording starttime.  The latter is
uglier, IMO, but has one advantage -- if program gets recorded in
multiple parts for whatever reason (backend restart, stop/reactivate,
etc.), there is a one to one correspondence between each recording
part and the new info.

David
-- 
David Engel
gigem at comcast.net


More information about the mythtv-dev mailing list