[mythtv] [PATCH] Autoexpire blocked by missing file.
mccoyn at gmail.com
Wed Mar 9 16:20:52 UTC 2005
Thanks for the tips. I will rework it tonight so it fits better and
send an updated version. I didn't realize the tabs were a problem,
but now when I open the patch I see it has made a mess of things. I
will clear that up.
> Is there a reason for this, why not just set pginfo = NULL when
> declared above?
That will work. I orginally didn't have anything there and I got an
warning saying possible use of unitialized value. I just added that
line to get rid of the warning. NULL might be better.
> Might want to make these VERBOSE calls VB_IMPORTANT.
Can do. I copied the VERBOSE calls from another file, where the
cannot delete file is reported before this patch. I also copied the
LogEntry call, which may not be needed.
> Do you really need this loop above? Can't you just use the "i" iterator
> you were using above since that is pointing to the item we're expiring?
I got an error because the "i" iterator is a reverse_iterator and
erase() expects a forward iterator. I could be missing something
here; I've spent the last couple of years in mostly C code so I'm a
bit rusty. I think, at the very least I'll change it to use the
std::advance() function to clean up the code a bit.
Thanks for taking the time to look at it and provide comments.
More information about the mythtv-dev