[mythtv] [PATCH] Fix (now broken) screen settings

Nigel Pearson nigel at ind.tansu.com.au
Wed Mar 9 07:01:04 UTC 2005

	Thanks for taking the time to look into this, Bruce.
And sorry that it has taken me 24 hours to fix this.

>>     OK. Problem not evident on Max OS X, but it is on linux.
> I'm surprised. When you set your GUI size smaller than full screen
> and not in the upper left, turned off GuiSizeForTV then started
> playback, what happened? How could your Mac find the correct screen
> dimensions?

	Probably due to the Mac using very different videoout code
than the Xv/XVMC stuff.

> First problem was that the window size and shape was wrong:
> 2005-03-08 10:51:33.813 REQUESTED DIMENSIONS 0,0: 1400x1050
> 2005-03-08 10:51:33.813 RECEIVED DIMENSIONS 0,1400: 0x1050
> This was because the args were in the wrong order in mythcontext.cpp
> +void MythContext::GetScreenBounds(int &xbase, int &width,
> +                                  int &ybase, int &height)

	Yes, I worked that out after I rushed home last night :-(

> A little more care could have saved time =).

	Story of my life at the moment.

> Next, it now creates a 1400x1050 X window but the playback is
> still 0,0 640x480

	On Mac OS X, I got the "tiling" effect for a while before
the fullscreen playback starts. On Linux, I see the problem
you describe. It seems to be this stupid cut/paste error:

% cvs diff -r1.245 -r1.246 libs/libmythtv/tv_play.cpp
<             myWindow->setGeometry(0, 0, 
<                                   QApplication::desktop()->height());
 >             mainWindow->setGeometry(0, 0, width, height);
 >             mainWindow->setFixedSize(QSize(width, height));

i.e. I am an idiot.

	I just corrected this in CVS.

1) Recommend trying the following:
rm libs/libmyth/mythcontext.{cpp,h} libs/libmythtv/tv_play.cpp
cvs update
    to revert yesterday's patch and get this correction.

2) There may still be problems with the window sizing.
    (at the very least, I expect tiling/cropping issues)
    If so, try this revised version of yesterday's patch

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.general.10
Type: application/octet-stream
Size: 9894 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20050309/91c2f28f/patch.general.obj
-------------- next part --------------

Nigel Pearson, nigel at ind.tansu.com.au | "In this city I confess
Telstra BI&D, Sydney, Australia       |  god is mammon, more is less
Office: 8255 4222    Fax:  8255 3153  |  off like lemmings at the gun
Mobile: 0408 664435  Home: 9792 6998  |  I know better, still I run"

More information about the mythtv-dev mailing list