[mythtv] [PATCH] Fix (now broken) screen settings

Nigel Pearson nigel at ind.tansu.com.au
Tue Mar 8 04:56:00 UTC 2005


[My multiple screen sanity, simplify X11 screen settings, patch]

> This doesn't seem to do the right thing WRT GuiSizeForTV=0 .
> If on, it should playback in the same space as the GUI. Turning
> off this option should use fullscreen for TV playback.

	Fixing this was harder than expected. It involved some
structural changes in mythcontext.cpp, which will need some
review and more thorough testing.

	The attached patch has a new method,
MythContext::GetScreenBounds(...), which returns the dimensions
of the full screen. tv_play.cpp now uses this, instead of
getScreenSettings(...), which returned the GUI dimensions,
or the original X11-specific GetMythTVSettings().

	I also tried to simplify the dozens of places where the
dimensions were set in mythcontext.cpp. It was careful,
but I am not 100% sure that it will do the right thing in
resolution changing environments :-(

% cvs diff -u libs/libmyth/mythcontext.{cpp,h} 
libs/libmythtv/tv_play.cpp >../patch.general.9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.general.9
Type: application/octet-stream
Size: 9573 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20050308/a2d58b70/patch.general.obj
-------------- next part --------------


--
Nigel Pearson, nigel at ind.tansu.com.au|"Beware - I am a carrier
Telstra BI&D, Sydney, Australia      |          of surrealism"
Office: 8255 4222    Fax:  8255 3153 |  D  A
Mobile: 0408 664435  Home: 9792 6998 |  L  I



More information about the mythtv-dev mailing list