[mythtv] [PATCH] MythPhone - prevent sending garbage video when webcam grabs smaller video than we want to send

Paul Volkaerts paul.volkaerts at lineone.net
Thu Jan 27 14:05:49 EST 2005


> Hi,
> i have encountered a problem with mythphone when using a quickcam
> messenger
> and grabbing video in cif and sending it in cif.
> the problem is, that the qc cant do cif-modes. i.e. instead of 176x144 it
> opens in 162x124.
> this leads to problems when trying to send in cif.
> the attached patch does check if the actual width/height of the
> webcam are
> smaller than the res in we want to send. if it is it crops the
> image instead
> of scaling it.
> i dont know if this also happens when there is zoom enabled.
> also the transmitted image has now a green line at the bottom.
> doesnt look
> good, but at least you can see something now.
> perhaps the image should be padded with black pixels, dont know.

So what exactly happends when you say you "encoutered a problem"?  Does it
actually not work or does the picture not look right?

The reason I ask is that the "scaleYuvImage" procedure is meant to handle
taking a picture and resizing it, smaller or larger; which I think is still
what is needed here.  The "cropYuvImage" procedure takes care of getting rid
of part of the picture because you just don't want it; for example when
zooming in on the middle of an image, you want to shed the outer area.

So if it doesn't work, I'd rather fix the "scale" function than call the
"crop" function; if you see what I mean.

Paul





More information about the mythtv-dev mailing list