[mythtv] DVB AC3 Patch 1 - ScanStreams Segfault fix

Mark Anderson markjanderson at mail.com
Tue Jan 25 19:37:08 EST 2005


Folks,

This is the first in a series of patches that will ultimately lead to AC3 
audio working with DVB (at least in Australia). I am breaking the original 
patch apart so that the various fixes can be applied independently to the 
tree to make it easier for those with commit access to understand the 
changes. 

The problem addressed by this patch:

When the ScanStreams function in avformatdecoder encounters a codec that it 
doesn't have a decoder for it closes the input file, sets the ic variable to 
NULL and exits. This eventually results in a segfault when the ic variable is 
accessed later without guards. It also means that the rest of the streams are 
not searched for a valid codec, i.e. AC3.

The Fix:

Don't close the file, or set ic to null and simply continue the loop to check 
the remaining streams for a vaild codec.

Cheers,
Mark Anderson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ac3-scanstreams-crash-fix.diff
Type: text/x-diff
Size: 777 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20050126/b74f3f16/ac3-scanstreams-crash-fix.bin


More information about the mythtv-dev mailing list