[mythtv] [PATCH][mythweb] Simple mythgallery support

Kristian Kalweit kalweit at exorpro.de
Tue Jan 25 05:49:25 EST 2005


Chris Petersen schrieb:

>
> This means no "execution" code in the theme file unless absolutely 
> necessary; no objects unless absolutely necessary (your main 
> mythgallery script has an object, but all it does is call linear 
> functions -- objects have a LOT of unnecessary overhead, and shouldn't 
> be used unless there's a good reason for them); check for existince of 
> files before trying to interact with them; don't just rely on php 
> error messages to tell you what's going on.
>
> Anyway, your code doesn't pass my new rules, and since I'm busy 
> working on updating mythweb for the pending .17 release, I don't have 
> time at the moment to fix it.
>
> also, just call the files "gallery.php" -- I should really rename the 
> music one.  we already know that it's "myth"...
>
I looked at mythmusic.php and took this as base, so I thought this is 
the right way I have to do it. I assumed all code have to be in an 
object for easier future maintance. There are also PHP compiler caches 
available to speed this things up.

>
>> - no thumbs creation (currently using .thumbcache of MythGallery), is 
>> a future dependency to GD applicable?
>
>
> This is easy.  See my code reference for examples,  I don't mind 
> requiring ImageMagick -- seems that it's a pretty standard thing to 
> have installed.
>
Sure, but I think the thumbs have to be compatible and at the same place 
as mythgallery use and create it.
Maybe it is fine to put the thumbs creation in a extra class. So there 
can be special inerithance of this (one for GD, one for ImageMagicks, ...).

>> - you have to use the back button of the browser to navigate back
>
>
> shouldn't be hard to fix.
>
At my machine I did this already.

>> - hard coded 5 thumbs in a row
>
>
> No need to use tables unless absolutely necessary, either -- they're 
> slow, and not nearly as much fun to play with (granted, they're often 
> easier, but not always better).  A line of images with or without 
> <br/> tags -- use CSS and let them wrap if you want.

:-) I think I'm a little bit old school here. OK, I have to use div tags 
here.

>
> So this is nothing against you or your patch -- I think it's a great 
> idea to add mythgallery support -- it's just that I'm tired of the 
> half-finished music and video sections, and want to make sure that 
> anything new going in is really clean (and if anyone out there wants 
> to fix the music and video stuff, I don't have time to do it, and 
> would really love the help).
>
Thanks for your response. Maybe is better to pause my work on this and 
wait for your redesign and cleanup. Because at my machine I have what I 
want for the first step, see the galleries.

Are there other things to do, where I can help?

Kristian.


More information about the mythtv-dev mailing list