[mythtv] Re: [PATCH] mythmusic amd64 support yet again

Isaac Richards ijr at case.edu
Fri Jan 21 02:59:46 EST 2005


> On Wed, 12 Jan 2005 00:01:38 -0500, Kyle Schlansker <kylesch at gmail.com> 
wrote:
> > The attached patch is yet another rework to add x86_64 support for
> > mythmusic.  Basically this is just an upgrade of goom and a few
> > changes to synaesthesia.

I've applied this.

> > Ive fixed a memory leak in goom that was re-introduced in the last
> > version of the patch and also removed some unnecessary comments in
> > synaesthesia.cpp as requested by Isaac.

It wasn't the unnecessary comments, it was the unnecessary re-indenting that 
you did.

> > Isaac: was there more than one memory leak in goom?

Yes, the other one was pretty visible from looking at the diff.  I've fixed 
it, though.

> > I'd like to see if we can finally get this committed to cvs and then
> > work on any bugfixes necessary.  It would be nice to get more testers
> > and that will only happen once it gets committed.  I've gotten quite a
> > few emails about this, so I know people desire amd64 support for
> > mythmusic.

You are aware that you had goom's mmx support completely disabled with this 
patch, right?  =)  I also noticed a small logic error in the synaesthesia 
draw algorithm that lead to some corruption..  I've fixed everything I saw, 
though, and it seems to work well so I've checked it all in.

Isaac


More information about the mythtv-dev mailing list