[mythtv] [PATCH] Big DVB Patch V3.5 - MPEG TS

Taylor Jacob rtjacob at earthlink.net
Tue Jan 11 11:00:32 EST 2005


> As you might know the only AC3 I've got is also on stream type = 6
> [private data] with an AC3 descriptor. 0x81 doesn't seem to be used for
> AC3 in this part of the world. I'm a bit scared of the day when I'll
> accidentally be "listening" to an EPG or some other non-AC3 data through
> the surround system. The speakers might even take some punishment if you
> have it on loud are are not quick enough to turn it off, and the drivers
> are not cheap so it would suck big time if that happened. :-)

I agree, but I don't know what else we can do.. PrivateTypes is possible but
that would be a HUGE list of exceptions.. The only thing that would cause this
to happen is the 0x81 descriptor in the PMT ALWAYS being parsed as AC3.. If
ffmpeg checks the AC3 CRC then this isn't a big deal.. An EPG (or any other
stream for that matter) having a valid AC3 header + payload seems crazy, but I
don't know that it does.. Also if you send the ac3 stream to a reciever I can't
believe most would try to decode improper data either.. I gotta think about it
some more..

> I think I would prefer:
>
>     pmt[p++] = (*es).Type == ES_TYPE_AUDIO_AC3 ? 0x81 : (*es).Orig_Type;
>
> but maybe that's just me... :)

Thats why I left the DVB-Patch code alone.. That is Much nicer looking.. :)

Taylor


More information about the mythtv-dev mailing list