[mythtv] [MASSIVE PATCH] BIG DVB PATCH V3.5 Released

Mark Anderson markjanderson at mail.com
Mon Jan 10 02:40:23 EST 2005


On Mon, 10 Jan 2005 06:16 pm, you wrote:
> Right, I've had a go with the AC3 patch against DVB Patch V3.5.
>
> I modified it slightly (not stomping on anyone's toes here):
>
if you can help get the transport.c stuff sorted out then you are forgiven :-)

> - I removed the transform.c stuff (that is apparently fixed)
I think you still need it to stop the stuttering. The fix in transform was to 
supposed to fix the need for the mpeg.c startcode hack but doesn't here in 
oz. The changes I added to transpform.c stop it from treating AC3 packets 
that happen to start with 80 from being treated as "normal" AC3 packets and 
transforming them. These packets would get the 4 byte header added  by 
transform and passed to the decoder which didn't recognise them since the 
header that wasn't pulled off by mpeg.c because of the hack to get the rest 
of the packets from working... 

> - I changed wantac3 to prefer_ac3 to match what was in sitypes.h - horses
> for courses...
of course of course.

> - I didn't remove the "enc->channels = 2" in avformatdecoder.cpp.  This
> stopped the software AC3 from working.  Is it necessary?
>
I noticed that when I was patching across to 3.5, I didn't mean to make or 
even remember making that change, maybe diff is a little confused.

> I have two thoughts about the ugly hack in mpeg.c.  Either the broadcasters
> here are not sending a 0x80 startcode, or the AC3 packet isn't aligned with
> the pes packet.
>
The broadcasters are not sending the 80 startcode. There is code in 
transform.c that is supposed to put in the four byte header (80 + 0 + len hi 
+ len low) however it doesn't seem to work. The hack to mpeg removes the need 
for the four byte header in mpeg.c but of course means that it wont be 
compatible. I got close to getting transform.c working but no cigar just yet. 

> Do any of you guys get horrible blockyness watching Nine HD (and to a
> lesser extent Ten HD)?  
Yes, I have been assuming my processor can't keep up (p3 2.6) tried XvMC but 
that asserted all the time.

> I can make it go away completely by recording the 
> transport stream, but I don't think mpegts.c is quite finished as I never
> get any audio on any channel.
>
> Maybe the pes filtering in my card is crap.
>
> Tim.
>
>
> -----Original Message-----
> From: mythtv-dev-bounces at mythtv.org [mailto:mythtv-dev-bounces at mythtv.org]
> On Behalf Of Mark Anderson
> Sent: Monday, 10 January 2005 2:52 PM
> To: mythtv-dev at mythtv.org
> Subject: Re: [mythtv] [MASSIVE PATCH] BIG DVB PATCH V3.5 Released
>
> <snip>
>
> > >>So far, v3.5 is much more stable, mythbackend and mythfrontend hasn't
> > >>crashed yet in 4 hrs (unlike v3.4 where it crashes frequently).
> > >
> > >Hmmm, I couldn't even get mine running for two minutes, I must have done
> > >something wrong 'cause noboby else seems to have the problems I had. Btw
> > > what cvs command did you use to get the myth code to patch the 3.5
> > > onto? There doesn't seem to be any tags for the dvb patches so I use
> > > the date which may not work depending on when the patch was created
> > > within the
>
> day
>
> > > and what gets commited after it.
> >
> > I always checked out the latest version, "cvs -z3 -q -d
> >
> > :pserver:mythtv at cvs.mythtv.org:/var/lib/mythcvs co mythtv", the patches
> >
> > almost always applies cleanly.
>
> Only if you checkout close to the release of the patch.
>
> I built 3.5 against CVS from this morning and it now works fine. Must have
> checked out at a bad time (-D20050108).
>
> > >>Recordings with AC3 seems broken (may me due to Mark's patch?). will
> > >>find out more later.
> > >
> > >Recording AC3 works fine in my setup. In what way is it broken?
> >
> > no audio .. I recorded a few programs and it all went fine, until when I
> > tried to watch "Law & Order: Criminal Intent" on channel 10, there's
> > video but no audio. Will test more tonight.
>
> Can you show me the log from the backend when it starts recording?
>
> > Regards.
>
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev


More information about the mythtv-dev mailing list