[mythtv] [PATCH] Patch to fix rounding errors from Aspect
Ratiosettings
Mark Edwards
irish at irishmark.co.uk
Tue Jan 4 11:53:38 EST 2005
> [mailto:mythtv-dev-bounces at mythtv.org] On Behalf Of Terry Barnaby
>
> This patch fixes problems with rounding errors caused by the
> X-Servers rounding of the DisplaySize configuration parameter.
>
> The patch also adds a new Aspect setting "Fill" which will
> take the incoming Video and "fill" the display with the
> picture cropping as necessary.
>
[snip]
>
> Could someone check this code to make sure it will not break
> anything ?
> The patch works well for me, I now have a good quality
> picture on my Via EPIA M10K box with a digital TV source.
Nice idea, but I think you've broken some of the other modes?
For case 3 (16/9 Zoom) you set the XJ_aspect to 4/3
Also cases 4 and 5 seem wrong in the same way?
[Note: I can't check this properly as I'm still at work]
Mark
case 3:
- XJ_aspect = (16.0 / 9);
- letterbox = 2;
+ XJ_aspect = (4.0 / 3);
+ letterbox = kLetterbox_16_9_Zoom;
break;
case 4:
+ XJ_aspect = (16.0 / 9);
+ letterbox = kLetterbox_4_3_Zoom;
+ break;
+ case 5:
XJ_aspect = (4.0 / 3);
- letterbox = 3;
+ letterbox = kLetterbox_16_9_Stretch;
+ break;
More information about the mythtv-dev
mailing list