[mythtv] [PATCH] MythMusic fixes for proper ID3 Tag writing + Paul's patches

[Colin Guthrie]

Hi,

Attached is a patch to write ID3 tag correctly and two of Paul's patches 
previously posted for the convenience of the patcher!

My original hack to "convert" ID3v2.4 tags to ID3v2.3 tag is incorrect 
and results in corrupt tags.

I was unaware that the top bit is no longer used in v2.4 to represent a 
text frames length, unlike in v2.3 where all 8 bits were used.

This was fine for most frames but any frame > 63 bytes long would be 
effectivly corrupted (NB 63 bytes as unicode)

The attached patch makes Myth Music stick to ID3v2.4 tags throughout 
thus avoiding the problem, although the v2.4 are less supported in other 
apps & standalone players.

Juk and amarok both support them as does the libmad plugin for xmms.

If enough people are upset by this, I'll write an contrib program that 
can be run on your collection of MP3s which will convert it from 2.4 -> 2.3.

That said, why use MP3s anyways??? Oggs/FLAC are better ;)

Also attached for the convenience of the patcher are Paul's two patches 
relating to the metadata editor (music-ui.xml files in other themes) to 
go into MythTV and his default music-ui.xml patch and his metadata.cpp 
fix to ensure the compilation_artist is written to the DB correctly to 
go into MythMusic.

Unless I've missed something, all the attached patches should be applied.

PS As part of my patch I've also fixed the encoding of the Genre as per 
the ID3 Specs to support random genre names as well as standard ones 
(tho' the libmad XMMS plugin ignores random genres, the specs clearly 
state it is allowed). Numerals are used whenever possible.

Col.


-- 

+------------------------+
|     Colin Guthrie      |
+------------------------+
|   myth at colin.guthr.ie  |
| http://colin.guthr.ie/ |
+------------------------+
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mythmusic_id3_fix.diff.bz2
Type: application/x-bzip2
Size: 2665 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20050209/c0d39bda/mythmusic_id3_fix.diff-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mythmusic_pauls_db_and_ui_fix.diff.bz2
Type: application/x-bzip2
Size: 1983 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20050209/c0d39bda/mythmusic_pauls_db_and_ui_fix.diff-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mythtv_pauls_ui_fixs.diff.bz2
Type: application/x-bzip2
Size: 2506 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20050209/c0d39bda/mythtv_pauls_ui_fixs.diff-0001.bin