[mythtv] [patch][i18n] MythMusic fix unicode handling for metadata - fix needed....

[Colin Guthrie]

Colin Guthrie wrote:
> The trailing P4 garbage on the end (actually id3v2's attempt at decoding 
> TPE4 as unicode and getting P4) seems to indicate something is wrong.
> 
> I'll look into it and work on a patch immediately.

Just updating the list as to progess...

OK, it looks like my version of libid3tag is calculating the size of the
TXXX frame totally wrong (no surprises there - it's a crap library,
there is already a hack for this lib I had to write in MM's cvs....).

It's calculating the length as 0x00 0x00 0x01 0x05 where as it should be
0x00 0x00 0x00 0x85.

Now, as I write these numbers down, I don't think it's a coincidence
that 0x85 becomes 0x01 0x05 as it's basically overflowing a 16 bit value
  and treating it as 8 bit. I'm guessing it's to do with signed vs.
unsigned arithmatic....

I'll look further and see if I can get a hack going.

All for 6 blooming bytes...

Although, that said, I wonder how it would cope with e.g. Titles longer
than 0x80 bytes........

Actually... perhaps it's the hack that's at fault..... ;) I'm looking...


Col.

-- 

+------------------------+
|     Colin Guthrie      |
+------------------------+
|   myth at colin.guthr.ie  |
| http://colin.guthr.ie/ |
+------------------------+