[mythtv] [PATCH] MP4 MetaIO support

[Simon Kenyon]

On Monday 07 February 2005 15:24, you wrote:
> Simon Kenyon wrote:
> >On Saturday 05 February 2005 19:33, Lonnie Hutchinson wrote:
> >>This patch moves the metadata stuff from aacdecoder into metaiomp4 and
> >>adds the ability to update the tags in the files.
> >>
> >>Please include this in CVS for the 0.17 release if possible. Thanks.
> >
> >sorry for asking this, but my C++ is not up to scratch
> >just checked out the source from CVS and i'm getting this error.
> >it looks ok to me so i cannot see what is going wrong
> >
> >thanks
> >--
> >simon
> >
> >g++ -c -pipe -Wall -W -g -I/usr/include/SDL -D_REENTRANT -D_REENTRANT
> > -fPIC -D_GNU_SOURCE -DPREFIX=\"/usr\" -DHAVE_MMX -DQT_THREAD_SUPPORT
> > -DQT_PLUGIN -I/usr/qt/3/mkspecs/linux-g++ -I. -I/usr/include
> > -I/usr/include/cdda -I/usr/qt/3/include -I/usr/X11R6/include -o
> > metaiomp4.o metaiomp4.cpp metaiomp4.cpp: In member function `virtual
> > Metadata*
> >MetaIOMP4::read(QString)':
> >metaiomp4.cpp:334: error: invalid conversion from `int' to `const char*'
> >metaiomp4.cpp:334: error:   initializing argument 1 of
> > `QString::QString(const char*)'
> >make: *** [metaiomp4.o] Error 1
>
> The Metadata object's constructor requires an lcompilation_artist argument
> that is not being passed in metaiomp4.cpp. Metadata constructor:
>     Metadata(QString lfilename = "", QString lartist = "", QString
> lcompilation_artist = "", QString lalbum = "", QString ltitle = "", QString
> lgenre = "", int lyear = 0, int ltracknum = 0, int llength = 0, int lid =
> 0, int lrating = 0, int lplaycount = 0, QString llastplay = "", bool
> lcompilation = false)
>
> Code in metaiomp4.cpp:
>     Metadata *retdata = new Metadata(filename,
>                                      artist,
>                                      album,
>                                      title,
>                                      genre,
>                                      year,
>                                      tracknum,
>                                      length);
>
> The error is coming from the attempt to use year as the lgenre argument.
>
> Unfortunately, I'm not the person to fix it, as I don't really have a clue
> as to what it is actually doing.

thanks for that
i thought i had counted the args - i missed the compilation_artist one
seems like the code is borked
--
simon