[mythtv] Re: Re: [PATCH] Add smart playlists to mythmusic

Paul mythtv at dsl.pipex.com
Sun Feb 6 14:10:30 UTC 2005


Isaac wrote:

>On Saturday 05 February 2005 02:19 pm, Paul wrote:

<snip>

>> On issue I did notice is the recent changes make to
>> MythThemedDialog::paintEvent()
>> causes the MythMusic screen to not redraw properly when returning from
the
>> SmartPlaylist editor dialog. You can only see the outer edges around the
>> selection dialog
>> but it clearly has not redrawn itself. If I comment out the recent
changes
>> the screen then
>> redraws properly.

>I can't reproduce this at all. What theme are you using? Which visualizer?
>Is it set to switch the vis on every song?

>Isaac

Just tried a clean cvs update of mythtv and mythmusic and this is 100%
reproducible with the 3 themes I tried (Blue, GANT, and Titivillus). It's a
lot less noticeable with Blue and Titivillus, they just seem to redraw the
background, GANT part redraws the tree background image I think.

Steps to reproduce.

1. From the playback screen press MENU then select 'Smart Playlists'.

2. In the Smart playlist selection dialog select a playlist then press
'Edit'

3. In the Smart Playlist Editor press ESCAPE / BACKUP

The selection dialog is now displayed again with the partly redrawn music
playback screen behind. It doesn't affect the working of mythmusic.
Its only cosmetic, it just looks a little ugly that's all. When you close
the
selection dialog the screen then redraws properly anyway.

Looking at the new code in MythThemedDialog::paintEvent() a
ThemedDialog is only redrawn when it is the current widget which
it isn't when there is a popup dialog on top as in this case.

I think the difference between the GANT theme and the others is that it has
more images contained in the 'background' container which seems to be
always drawn regardless of whether the themed dialog is at the top of
the stack or not.

Paul




More information about the mythtv-dev mailing list