[mythtv] [PATCH] mythmusic: autoplay of CDs

Herman Kuiper herman at frontier.nl
Sun Apr 10 13:43:24 UTC 2005


Hi,

> Not applying this, because:
> - it was generated with -b -B, which completely trashes the indentation
> of a  few changes you made.

Ah ok, I didn't know that.

> - it duplicates quite a bit of code into playbackbox.cpp

Do you mean: "within playbackbox.cpp" - if so, I further removed some 
duplicity. If you mean "compared to databasebox.cpp" I would like to 
disagree slightly: I re-use the actual CD reader thread, and only duplicate 
the stuff to setup timer and thread, which are different from the 
databasebox.

Attached a new patch (diff'ed to todays CVS), which includes lots of 
white-space diff's as my editor strips end-of-line whitespace.

If you still have issues with duplicity, could you give me something more 
on what I might need to change?

	Herman

(I'll re-submit my other mythmusic patch without -b -B as well)

-----------------------------------------------------------------
Herman Kuiper - m: herman at frontier.nl - w: http://www.frontier.nl
Beech Ave 162 - 1119 PS  Schiphol-Rijk - t/f: 020-6589034/6142816
-------------- next part --------------
A non-text attachment was scrubbed...
Name: autoplay.diff.gz
Type: application/x-gzip
Size: 14353 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20050410/2b1f3c7c/autoplay.diff.bin


More information about the mythtv-dev mailing list