[mythtv] Re: [PATCH] mythtv player bookmarks for external files

Leo Weppelman leo at wau.mis.ah.nl
Fri Apr 8 21:21:38 UTC 2005

On Thu, Apr 07, 2005 at 10:58:45AM +0800, Peter Marriott wrote:
> > I have created a patch that enables the mythtv player to save
> > bookmarks to the database when it is used to play external files.

I like that! I missed your initial post...

> > I'd appreciate any feedback.... My first patch, so hopefully I
> > followed standards correctly.

I was staring at your patch, and I saw that you were using:
+   // When using mythtv to play files not recorded by myth the title is empty
+   // so bookmark is saved to videobookmarks rather than recorded
+   if (title.isEmpty())

I don't trust this condition... Shouldn't you be using 'isVideo' to
determine this? Besides that from reading the code, 'isVideo' looks more
correct, printing the title in my setup yielded basename(<videofile>).
But I should add that I am not running a stock version of mythvideo ;-)

> Any chance this could be include in 0.18?  If not any suggestions on
> how I could change it so it would be accepted?   Sorry if I am just
> being too impatient :)

Can't help you with this ;-)


More information about the mythtv-dev mailing list