[mythtv] Re: Re: [PATCH] delete recording schedules
David Engel
gigem at comcast.net
Sat Apr 2 18:03:06 UTC 2005
On Sat, Apr 02, 2005 at 12:44:59PM -0500, Jeremiah Morris wrote:
> >kSingleRecords are deleted when mythfilldatabase runs the next day.
>
> Why should the delete be so arbitrary? A movie that finishes at 10 AM
> have its schedule hang around for most of a day, but a movie that
> finishes at 3 AM will have its schedule deleted almost immediately.
If a recording ends at 3am and mythfilldatabase runs a 4am, that is
not when "mythfilldatabase runs the next day".
> It
> makes no sense at all to me that the two would be related.
It makes perfect sense because mythfilldatabase is where any database
housekeeping is done.
> >They are left in the database because they are needed to support
> >reactivating a recording.
>
> As I read it, the patch only runs when the recording completes
> successfully, so it's entirely in the past. How would you reactivate a
> recording when the show has aired and gone? This is only for
"completes successfully" is a misnomer. That code runs when a
recording is stopped for any reason and includes the cases where the
user manually stops or deletes a recording while it is still in
progress. Stopping or deleting prematurely are specific cases the
reactivation logic is meant to handle.
David
--
David Engel
gigem at comcast.net
More information about the mythtv-dev
mailing list