[mythtv] [PATCH] optionally re-record auto-expired programs

Chris Pinkham cpinkham at bc2va.org
Fri Apr 1 20:10:20 UTC 2005


> So after much investigating (and learning!) it seems that the problem
> is that the returned value is a string and not numeric, so this should
> do the trick.
> 
> Change:
>                 if (gContext->GetSetting("RerecordAutoExpired", 0))
> to
>                 if (gContext->GetSetting("RerecordAutoExpired", 0) == "1")
> 
> I did test it quite thoroughly this time on my 0.16 install, but if
> someone could try it against cvs and generate a proper diff would be
> very cool.
> 
> Oh, and sorry for all the "spam", I promise to test thoroughly next
> time _before_ mailing the dev list with my ramblings.  :)

I replied to one of the originals but forgot to send it to the list, so
instead it was a direct reply.

Now I can see what you mean. :)  And since you're in a learning mood,
instead of your "to" line, it's preferable to use GetNumSetting like this:

if (gContext->GetNumSetting("RerecordAutoExpired", 0))

No need to submit a patch, I just committed this to CVS now.

Thanks for tracking this down.
-- 

Chris



More information about the mythtv-dev mailing list