[mythtv] [PATCH] filldata.cpp improve logic for incomplete days

BP lists at qucae.com
Sun Sep 26 08:00:31 EDT 2004

Mailing Lists wrote:
> This patch better identifies which days have incomplete data. The 
> previous code did not work for me because 14/53 of my channels were 
> filled.  This way, if any channels are incomplete, it triggers a 
> re-download.  I have only tested this with a single lineup using the 
> datadirect service, so someone with multiple sourceid's (lineups) should 
> make sure this will work properly.  I _think_ it should.  I did not 
> adjust the logic for the tv_grab_nz code, but if it should be changed, 
> let me know.
> as a side note, do any of the current grabbers need the fix_end_times() 
> code.  I initially wrote that to compensate for the limitation of  the 
> old  tv_grab_na, so unless the other grabbers need it, it should 
> probably be removed/disabled.
> Joe.
I don't see how this is better logic.  It simlpy will always download 
data if a single channel has none existing.  That's not logic, it's a 
simplistic trigger.  For me, this will always download as I have a 
number of digital music channels that never have data.  Yes, I could 
make the effort to remove those channels, but I'm too lazy.  I'm 
guessing there are numerous users who are also too lazy or have channels 
with no data they don't want to remove.  Your removal of a threshold 
will put extra load on lots of users.  I'm not sure what the solution 
is.  I just don't think this is it.

More information about the mythtv-dev mailing list