[mythtv] [Patch] copy and paste bug in channelsettings.cpp

[Isaac Richards]

On Saturday 25 September 2004 07:52 pm, Kenneth Aafløy wrote:
> On Sunday 26 September 2004 01:03, Isaac Richards wrote:
> > On Saturday 25 September 2004 06:14 pm, Kenneth Aafløy wrote:
> > > On Saturday 25 September 2004 23:50, Isaac Richards wrote:
> > > > On Saturday 25 September 2004 04:59 pm, John Pullan wrote:
> > > > > On Sat, 2004-09-25 at 22:29 +0200, Kenneth Aafløy wrote:
> > > > > > On Saturday 25 September 2004 21:59, John Pullan wrote:
> > > > > > > I've just noticed that the widget that looks after the
> > > > > > > hp_code_rate was actually using the fec entry :-/
> > > > > >
> > > > > > Hmm, the fec and hp_code_rate is sharing the same data field, so
> > > > > > this is an incorrect assumption. :p
> > > > >
> > > > > Ooops my bad. (Bit confusing though)
> > > >
> > > > More than a bit confusing.  That's plain old bad design, there.
> > >
> > > Why, they are never used at the same time, since a card can't be both
> > > dvb-s/c and dvb-t...because then it will have two frontends, which will
> > > be enumerated in the dev directory as adapterx/frontend0 and
> > > adapterx/frontend1.
> >
> > It's like having a class called 'Checkbox' when it implements a list
> > widget. Things should have descriptive names that accurately reflect what
> > they are/do.
>
> Well, I would not care to use that comparison in this case, since
> hp_code_rate is the fec setting (primary) of dvb-t, but you would not know
> that.

'Course I wouldn't, I didn't write the code in question, and couldn't care 
less about dvb in general.  Regardless, it's bad design, and at the very 
least, a very good reason for what's commonly called a 'comment' in 
programming speak.

Isaac