[mythtv] [Patch] copy and paste bug in channelsettings.cpp
Isaac Richards
ijr at po.cwru.edu
Sat Sep 25 19:03:10 EDT 2004
On Saturday 25 September 2004 06:14 pm, Kenneth Aafløy wrote:
> On Saturday 25 September 2004 23:50, Isaac Richards wrote:
> > On Saturday 25 September 2004 04:59 pm, John Pullan wrote:
> > > On Sat, 2004-09-25 at 22:29 +0200, Kenneth Aafløy wrote:
> > > > On Saturday 25 September 2004 21:59, John Pullan wrote:
> > > > > I've just noticed that the widget that looks after the hp_code_rate
> > > > > was actually using the fec entry :-/
> > > >
> > > > Hmm, the fec and hp_code_rate is sharing the same data field, so this
> > > > is an incorrect assumption. :p
> > >
> > > Ooops my bad. (Bit confusing though)
> >
> > More than a bit confusing. That's plain old bad design, there.
>
> Why, they are never used at the same time, since a card can't be both
> dvb-s/c and dvb-t...because then it will have two frontends, which will be
> enumerated in the dev directory as adapterx/frontend0 and
> adapterx/frontend1.
It's like having a class called 'Checkbox' when it implements a list widget.
Things should have descriptive names that accurately reflect what they
are/do.
Isaac
More information about the mythtv-dev
mailing list