[mythtv] [PATCH] View log entries in System Status (Update1)

Kevin Kuphal kuphal at dls.net
Thu Sep 2 09:50:28 EDT 2004


Chris Pinkham wrote:

>>Attached patch should address these issues
>>
>>Kevin
>>    
>>
>
>Couple questions/comments about the logs and status screen.
>
>I think that the LogEnabled setting in globalsettings.cpp should probably
>inherit from BackendSetting instead of GlobalSetting.   GlobalSetting
>isn't really Global, it applies only to the frontend that you set it on.
>If you don't run the frontend setup on a backend then that backend
>won't log even if you turned logging on on the frontend.  Making this
>a BackendSetting would truly make it global between all frontends and
>backends and all event logging would be turned ON/OFF by the one
>setting.
>
>For displaying the log in the status screen.  I have been sitting on some
>code which enables scrolling in this screen by basically keeping an
>array (QMap<int,QString> really) of lines to be displayed.  The various
>do*Status() methods would simply fill in the QMap and the scrolling code
>is generic and just keeps track of what portion of the QMap is actually
>being displayed in the on-screen list.  This works for things that
>can't be created using a simple query like you have for the logs.
>Do you think that something like this might be more flexible than the
>current way you have the scrolling implemented?  I wrote my patch because
>I needed to have a scrolling list for the Job Queue status to show what
>jobs were currently running, pending, etc..  I haven't committed the
>Job Queue patch to CVS yet, so the statusbox changes aren't there either.
>Attached is the diff to current CVS of my statusbox.h and statusbox.cpp
>files.  Can you take a look at how I implemented the scrolling and see
>if it might be more flexible to adding new status lists in the future.
>If so, you could merge in my scrolling changes to your tree and
>resubmit the log patch and I can get that in CVS then I can take my
>Job Queue status changes and merge them in when I commit the Job Queue
>itself.  I'm open to ideas, but want to see if we can make adding in
>a new scrolling status list easy so we don't to recode large
>portions of statusbox.cpp.
>
>I like the way you made the iconlist more dynamic rather than having all
>those case statements hard-coded which made it harder to add any new items
>unless they were at the end.
>  
>
I like it alot.  I'll see about getting the scrolling part working with 
my changes and resubmit.  Thanks!

Kevin



More information about the mythtv-dev mailing list